Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue when dropping DeviceManager #165

Merged
merged 2 commits into from
Oct 13, 2024
Merged

Fix issue when dropping DeviceManager #165

merged 2 commits into from
Oct 13, 2024

Conversation

Xoffio
Copy link
Contributor

@Xoffio Xoffio commented Sep 30, 2024

Fixes #164

s1341
s1341 reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@s1341 s1341 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about checking the error?

@Xoffio
Copy link
Contributor Author

Xoffio commented Oct 11, 2024

I just removed the unnecessary variable. The error is not handle in the node version -> https://github.com/frida/frida-node/blob/main/src/device_manager.cc#L56

@s1341 s1341 merged commit 0df1bd0 into frida:main Oct 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1341 s1341 s1341 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeviceManager is not being dropped properly
2 participants
@Xoffio @s1341